Revise welcome page #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
requested changes
Mar 6, 2019
packages/web/webpack.config.js
Outdated
| "spdlog": path.join(vsFills, "spdlog.ts"), | ||
| "native-watchdog": path.join(vsFills, "native-watchdog.ts"), | ||
| "iconv-lite": path.join(vsFills, "iconv-lite.ts"), | ||
| "welcome": path.join(vsFills, "welcomePage.ts"), |
There was a problem hiding this comment.
The alias will need to match the import, so in this case vs/workbench/parts/welcome/page/electron-browser/vs_code_welcome_page.
|
We should be careful about this. Wouldn't want to miss an update on their welcome page. Not sure if theres really a way around that. |
|
Ahh, true, maybe we should patch it after all? I suggested the alias but the updates are definitely a good reason to go with patching. |
|
Should we consider using the update modal that we currently have on our hosted version and stick to using that for all coder-related stuff? |
|
Closing this one. Going to make a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Coder specific links, remove non-working links.